Skip to main content.
home | support | download

Back to List Archive

Re: patch for SwishGetStructure()

From: Bill Moseley <moseley(at)not-real.hank.org>
Date: Tue Jan 30 2007 - 22:15:30 GMT
On Wed, Jan 31, 2007 at 01:02:49AM +0300, Antony Dovgal wrote:
> >I don't mind.  Are you actually using that structure value?  I mean if
> >you are setting it then you should know what it is.
> 
> Yes, but as far as I understand the value is a bitmask, right?
> With this function you can get the value, add another bit to it and set it 
> back, instead of storing the value somewhere else (to change & set it 
> later). 

Yes, I think so.   That structure value has probably been in swish
since the beginning, and I always assumed nobody ever used it. ;)


> >Could I ask you to also supply patches for the *.pod and CHANGES.pod
> >files?  The patch will set longer if I have to write the docs. ;)
> 
> Sure, no problem.
> I'll do that tomorrow.
> 
> >Swish::API probably needs to be updated, too, but Peter may
> >want to do that since there's a version on CPAN.
> >
> >In a perfect world there would be tests for every feature, too.
> 
> Well, in a perfect world all function names would be consistent and clear, 
> and every function would have a nice docs.
> Too bad our world is not perfect.. =)

Yes, poking around the swish internals can be painful.

-- 
Bill Moseley
moseley@hank.org

Unsubscribe from or help with the swish-e list: 
   http://swish-e.org/Discussion/

Help with Swish-e:
   http://swish-e.org/current/docs
   swish-e@sunsite.berkeley.edu
Received on Tue Jan 30 14:15:30 2007