Skip to main content.
home | support | download

Back to List Archive

F_OPEN_TEXT in index.c

From: Kyle Judson <kjudson(at)>
Date: Thu Dec 19 2002 - 23:06:36 GMT
I was having problems with SWISH 2.2.1, the old xml parser and some =
files on NT 2000.  The parser was complaining about them being "not well =
formed" and stuff.

I tracked the problem to the fact that the file is opened in index.c as =
F_READ_TEXT and then when it is read by read_stream in file.c the buffer =
is terminated at filelen instead of bytes read and the filelen was not =
updated.  In windows the test read strips some characters, in my case =
the 0x0D of the CR/LF pair at the end of each line.   The result was =
that the buffer was not completely filled and there was garbage at the =
end that the parser was choking on.

I changed the F_READ_TEXT to F_READ_BINARY and that seems to have solved =
my problem but I am worried about an unforeseen side effect.  Am I OK?

I checked CVS and none of the affected code seems to have changed.



Due to deletion of content types excluded from this list by policy,
this multipart message was reduced to a single part, and from there
to a plain text message.
Received on Thu Dec 19 23:06:51 2002